feat(agents-api): Remove auto_blob_store in favor of interceptor based system #977
Conversation
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
Signed-off-by: Diwank Singh Tomer <[email protected]>
feat(agents-api): Add entry queries
Signed-off-by: Diwank Singh Tomer <[email protected]>
…d system Signed-off-by: Diwank Singh Tomer <[email protected]>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14144715 | Triggered | Generic Password | c85c2fe | memory-store/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
CI Failure Feedback 🧐(Checks updated until commit ca5f4e2)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e158f3a in 1 minute and 32 seconds
More details
- Looked at
5962lines of code in91files - Skipped
0files when reviewing. - Skipped posting
7drafted comments based on config settings.
1. agents-api/agents_api/activities/embed_docs.py:14
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is compensated by the new interceptor-based system to handle large data offloading. - Reason this comment was not posted:
Confidence changes required:50%
The removal of theauto_blob_storedecorator is consistent across multiple files. This change aligns with the PR's intent to replace it with an interceptor-based system. However, the decorator's removal should be verified to ensure that the new system handles the same functionality.
2. agents-api/agents_api/activities/execute_system.py:36
- Draft comment:
Verify that the new interceptor system handles the functionality previously managed byload_from_blob_store_if_remote. - Reason this comment was not posted:
Confidence changes required:50%
Theload_from_blob_store_if_remotefunction call is removed, which was responsible for loading data from a remote blob store. Ensure that the new interceptor system handles this functionality.
3. agents-api/agents_api/activities/task_steps/base_evaluate.py:62
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is consistent with the new interceptor-based system for data handling. - Reason this comment was not posted:
Confidence changes required:50%
Theauto_blob_storedecorator is removed from multiple functions. This change should be consistent with the new interceptor-based system to ensure data handling is still managed correctly.
4. agents-api/agents_api/activities/task_steps/cozo_query_step.py:10
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is consistent with the new interceptor-based system for data handling. - Reason this comment was not posted:
Confidence changes required:50%
Theauto_blob_storedecorator is removed from multiple functions. This change should be consistent with the new interceptor-based system to ensure data handling is still managed correctly.
5. agents-api/agents_api/activities/task_steps/evaluate_step.py:10
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is consistent with the new interceptor-based system for data handling. - Reason this comment was not posted:
Confidence changes required:50%
Theauto_blob_storedecorator is removed from multiple functions. This change should be consistent with the new interceptor-based system to ensure data handling is still managed correctly.
6. agents-api/agents_api/activities/task_steps/for_each_step.py:11
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is consistent with the new interceptor-based system for data handling. - Reason this comment was not posted:
Confidence changes required:50%
Theauto_blob_storedecorator is removed from multiple functions. This change should be consistent with the new interceptor-based system to ensure data handling is still managed correctly.
7. agents-api/agents_api/activities/task_steps/get_value_step.py:11
- Draft comment:
Ensure that the removal of@auto_blob_store(deep=True)is consistent with the new interceptor-based system for data handling. - Reason this comment was not posted:
Confidence changes required:50%
Theauto_blob_storedecorator is removed from multiple functions. This change should be consistent with the new interceptor-based system to ensure data handling is still managed correctly.
Workflow ID: wflow_AjDxfoccjl58OUog
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
PR Code Suggestions ✨Explore these optional code suggestions:
|
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ca5f4e2 in 50 seconds
More details
- Looked at
53lines of code in4files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. agents-api/tests/fixtures.py:3
- Draft comment:
The import oftimeis unnecessary as it is not used in this file. Consider removing it to clean up the code. - Reason this comment was not posted:
Confidence changes required:50%
The import oftimeinagents-api/tests/fixtures.pyis unnecessary as it is not used anywhere in the file. Removing unused imports is a good practice to keep the code clean and efficient.
2. agents-api/agents_api/queries/sessions/create_session.py:11
- Draft comment:
The import ofResourceCreatedResponseis unnecessary as it is not used in this file. Consider removing it to clean up the code. - Reason this comment was not posted:
Confidence changes required:50%
The import ofResourceCreatedResponseinagents-api/agents_api/queries/sessions/create_session.pyis unnecessary as it is not used anywhere in the file. Removing unused imports is a good practice to keep the code clean and efficient.
3. agents-api/tests/test_session_queries.py:13
- Draft comment:
The import ofResourceCreatedResponseis unnecessary as it is not used in this file. Consider removing it to clean up the code. - Reason this comment was not posted:
Confidence changes required:50%
The import ofResourceCreatedResponseinagents-api/tests/test_session_queries.pyis unnecessary as it is not used anywhere in the file. Removing unused imports is a good practice to keep the code clean and efficient.
Workflow ID: wflow_4DsKSc8XWp0obflW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
User description
PR Type
Enhancement, Tests
Description
system_templateandforward_tool_callsfieldsChanges walkthrough 📝
8 files
Sessions.py
Add system template and tool call forwarding to session modelsagents-api/agents_api/autogen/Sessions.py
sessions
Implement PostgreSQL session management queriesagents-api/agents_api/queries/sessions
etc)
entries
Add PostgreSQL entry management queriesagents-api/agents_api/queries/entries
entries
temporal.py
Replace blob store with interceptor systemagents-api/agents_api/clients/temporal.py
count_sessions.py
New session counting functionalityagents-api/agents_api/queries/sessions/count_sessions.py
000016_entry_relations.up.sql
Improved entry relations leaf node handlingmemory-store/migrations/000016_entry_relations.up.sql
000015_entries.up.sql
Enhanced session and entry table functionalitymemory-store/migrations/000015_entries.up.sql
models.tsp
New session model fields and documentationtypespec/sessions/models.tsp
1 files
protocol
Refactor remote object handling and task protocolsagents-api/agents_api/common/protocol
1 files
tests
Update tests for PostgreSQL session and entry queriesagents-api/tests
1 files
update_developer.py
Enhanced error handling in developer update queryagents-api/agents_api/queries/developers/update_developer.py
decorator
name
1 files
patch_agent.py
Code cleanup and query naming improvementsagents-api/agents_api/queries/agents/patch_agent.py
1 files
env.py
Environment configuration updatesagents-api/agents_api/env.py
Important
Replaced blob store with interceptor system, added PostgreSQL session and entry queries, and improved error handling and test coverage.
auto_blob_storein favor of interceptor-based system intemporal.pyandinterceptors.py.store_in_blob_store_if_largeandload_from_blob_store_if_remotewithoffload_if_largeandload_if_remote.queries/sessionsandqueries/entries.system_templateandforward_tool_callsfields inSessions.py.000015_entries.up.sqland000016_entry_relations.up.sql.update_developer.pyandinterceptors.py.test_session_queries.pyandtest_entry_queries.py.env.py.utils.py.This description was created by
for ca5f4e2. It will automatically update as commits are pushed.